feat(silo): add verbosity argument to CLI interface#1175
feat(silo): add verbosity argument to CLI interface#1175
Conversation
|
This is a preview of the changelog of the next release. If this branch is not up-to-date with the current main branch, the changelog may not be accurate. Rebase your branch on the main branch to get the most accurate changelog. Note that this might contain changes that are on main, but not yet released. Changelog: 0.9.12 (2026-02-20)Features
|
Taepper
force-pushed
the
565-silo-verbosity
branch
from
65efc31 to
3d2611e
Compare
Taepper
force-pushed
the
565-silo-verbosity
branch
from
3d2611e to
094ac49
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| /// `positional_arguments`, `asks_for_help`, and `verbose_count` are only used | ||
| /// by the command line argument backend, other backends leave them empty/false/0. | ||
| class VerifiedConfigAttributes { |
There was a problem hiding this comment.
The doc comment on VerifiedConfigAttributes references positional_arguments, asks_for_help, and verbose_count, but those members are not part of VerifiedConfigAttributes (they’re on VerifiedCommandLineArguments). Consider moving this note to the VerifiedCommandLineArguments docblock (or rewording to avoid implying these fields exist on all VerifiedConfigAttributes).
| if (!arg.starts_with('-') || arg.starts_with("--")) { | ||
| expanded_args.push_back(arg); | ||
| } else { | ||
| for (char shorthand : arg.substr(1)) { | ||
| if (shorthand == 'v') { |
There was a problem hiding this comment.
expandArguments() drops the standalone "-" argument: for arg == "-", the else-branch iterates over arg.substr(1) (empty) and appends nothing, so verification succeeds with the argument silently ignored. Previously this would surface as an invalid option error. Handle this explicitly (e.g., treat "-" as an unknown option and keep it in expanded_args, or treat it as positional only when preceded by "--").
resolves #565
Summary
-v/--verbosecan be passed once for debug-level logging and twice for trace-level logging-vv..is also supportedPR Checklist
--helpmessage)